Add check for invalid conversion rate (SlowMist N3) #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clostao
changed the title
deblanco
previously approved these changes
Nov 9, 2023
GabrielMartinezRodriguez
previously approved these changes
Nov 15, 2023
deblanco
dismissed stale reviews from GabrielMartinezRodriguez and themself
via
a4279f5
deblanco
force-pushed
the
fix-invalid-conversion-rate
branch
from
b55805d to
a4279f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slowmist problem description:
If the value of conversion_rate.1 is 0, it may lead to a program panic. This is because in Rust, when performing
integer division, dividing by 0 will result in a panic. Such a situation is considered undefined behavior, and Rust
detects division by 0 at runtime and panics to ensure program safety.
Our response:
Applied suggested changes
Types of changes
What types of changes does your code introduce?